Fix case/whitespace sensitivity in duplicate label detection#1346
Merged
Fix case/whitespace sensitivity in duplicate label detection#1346
Conversation
resolve_duplicate_labels was using exact string comparison to detect duplicates, so workshops with the same name but different casing or whitespace would not get IDs appended to disambiguate them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jmilljr24
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
resolve_duplicate_labelsused exact Ruby string comparison to detect duplicate workshop labels in remote-select dropdownsHow did you approach the change?
.squish.downcasefor grouping/comparison, while preserving the original label text for displayAnything else to add?
utf8mb4_unicode_cicollation🤖 Generated with Claude Code